Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: unexpected querying all files when deleting an empty folder #1469

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Fix: unexpected querying all files when deleting an empty folder #1469

merged 1 commit into from
Sep 29, 2022

Conversation

topjohncian
Copy link
Member

Fix deleting an empty folder takes a too long time when the size of files is large.

Empty folders have no children, so the parameter of RemoveFilesWithSoftLinks is also an empty slice. Then, it builds and executes a query SELECT * FROM files with no WHERE conditions, which takes the longest time.

image

@HFO4 HFO4 merged commit 88e10ae into cloudreve:master Sep 29, 2022
@HFO4
Copy link
Member

HFO4 commented Sep 29, 2022

Nice catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HFO4 HFO4 HFO4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@topjohncian @HFO4